Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36045?usp=email )
Change subject: ms: hard preswapped VA gsm bits ......................................................................
ms: hard preswapped VA gsm bits
small * 127 can still be small enough to end up 0 after casting which breaks everything.
Change-Id: I44b95dced64208eebfb5214da034a5d49abdd0df --- M Transceiver52M/grgsm_vitac/grgsm_vitac.cpp 1 file changed, 13 insertions(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved pespin: Looks good to me, but someone else must approve
diff --git a/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp b/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp index 5779d9d..2016541 100644 --- a/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp +++ b/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp @@ -95,7 +95,7 @@ viterbi_detector(filtered_burst, burst_size, rhh, start_state, stop_states, 2, output);
for (unsigned int i = 0; i < burst_size; i++) - output_binary[i] = (char)(output[i] * -127); // pre flip bits! + output_binary[i] = output[i] > 0 ? -127 : 127; // pre flip bits! }
NO_UBSAN void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary,