Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 )
Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option
......................................................................
Patch Set 1:
(2 comments)
File firmware/ice40-riscv/icE1usb/usb_gps.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-e1-hardware-lint-66):
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/e28bfa68_e277…
PS1, Line 157: /* Check if PPS occured */
'occured' may be misspelled - perhaps 'occurred'?
Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-e1-hardware-lint-66):
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/f38f7f1c_55b8…
PS1, Line 173: else if (g_usb_gps.pps.set)
else should follow close brace '}'
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Ie5d163434323a23912228003add9870fafefedf9
Gerrit-Change-Number: 29611
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt(a)246tNt.com>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 04 Oct 2022 14:11:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment