[XS] Change in osmo-ci[master]: scripts/verify_log_statements: fix undefined name

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39911?usp=email ) Change subject: scripts/verify_log_statements: fix undefined name ...................................................................... scripts/verify_log_statements: fix undefined name Append it to "errors_found" instead of undefined variable "ignored". This makes it work similarly to further above: # Skip 'LOG("bla" fmt )' strings that typically appear as #defines. if fmt_re.match(quoted): if debug: errors_found.append(error_found(f, log.start(), 'Skipping define', log.group(0))) continue Fix the following bug: scripts/verify_log_statements.py:92:11: F821 Undefined name `ignored` | 90 | # hopefully eval broke because of some '## args' macro def 91 | if debug: 92 | ignored.append(error_found(f, log.start(), 'Ignoring', log.group(0))) | ^^^^^^^ F821 93 | continue | Change-Id: I4661d4677a1f0fc8d595985e73e2632b9a83b7d6 --- M scripts/verify_log_statements.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/11/39911/1 diff --git a/scripts/verify_log_statements.py b/scripts/verify_log_statements.py index a7b27d6..1590799 100755 --- a/scripts/verify_log_statements.py +++ b/scripts/verify_log_statements.py @@ -89,7 +89,7 @@ except: # noqa: E722 # hopefully eval broke because of some '## args' macro def if debug: - ignored.append(error_found(f, log.start(), 'Ignoring', log.group(0))) + errors_found.append(error_found(f, log.start(), 'Ignoring', log.group(0))) continue # check for errors... -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4661d4677a1f0fc8d595985e73e2632b9a83b7d6 Gerrit-Change-Number: 39911 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>