22 Apr
2025
22 Apr
'25
10:43 a.m.
Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40095?usp=email )
Change subject: personalization: discover all useful ConfigurableParameter subclasses ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40095/comment/5ae2b002_e9c557b9?usp=ema... : PS2, Line 497: is_abstract = False I guess a minor syntactic improvement would be implementation via a decorator instead of a class variable? Not critical at all, just my two cents.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40095?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4970657294130b6b65d50ff19ffbb9ebab3be609
Gerrit-Change-Number: 40095
Gerrit-PatchSet: 2
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Tue, 22 Apr 2025 08:43:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes