Attention is currently required from: keith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/29649
)
Change subject: osmo-bts-trx: respond to tx-attenuation config in real time.
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
That may probably collide with the power ramp done at startup. You may want to initiate
it only if the BTS is into some state, to avoid starting it while reading config at
startup
But anyway, I think you should in general not use that VTY config with something else than
"oml" there. you are expected to set it through OML osmo-bsc.
The problem is of course that I don't think right now we allow configuring TRX through
OML without having the whole osmo-bts restart atm. But I think on top of that there's
per-lchan atenuation applied, which can be configured by BSC on every new lchan. That
would be enough I think.
It could be merged if: the ramping is only applied when param != "oml" and when
making sure the ramping doesn't happen during initial cfg read.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/29649
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fa5e8130202fb509593db4132863b762b0f40b7
Gerrit-Change-Number: 29649
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Comment-Date: Thu, 06 Oct 2022 16:37:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment