Attention is currently required from: jolly, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 )
Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ......................................................................
Patch Set 7:
(4 comments)
File src/host/layer23/include/osmocom/bb/common/l23_app.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/5f7efc9c_fa33616c PS2, Line 19: bts
Not addressed.
Done
File src/host/layer23/src/common/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/13877ca7_a3e09b79 PS6, Line 301: "Setting up GSMTAP Um forwarding to '%s:%u'\n",
weird formatting, same above
Done
File src/host/layer23/src/common/vty.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/70962984_65937424 PS6, Line 170: see also 'gsmtap / category
could you clarify what you mean here?
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/82c8ef4a_741fb6c5 PS6, Line 188: TALLOC_FREE
Isn't TALLOC_FREE macro NULL-safe, btw?
Done