Attention is currently required from: fixeria, laforge, neels, osmith, pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40250?usp=email )
Change subject: sccp: Implement dpc_accessible()
......................................................................
Patch Set 3:
(1 comment)
File src/sccp_scrc.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40250/comment/918e4ab7_99944e... :
PS3, Line 75: inst
```
note: expected 'const struct osmo_ss7_instance *' but argument is of type 'struct osmo_sccp_instance *'
```
I believe the logs also need inst->ss7?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40250?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I16b0aa71db5be2daf7a8c52da829a38ad564eb7b
Gerrit-Change-Number: 40250
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 12 May 2025 15:00:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No