1 Aug
2025
1 Aug
'25
12:42 p.m.
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email )
Change subject: routing area: introduce ran_type on the RA
......................................................................
Patch Set 2:
(7 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/c7d40e7a_520e232c?us… :
PS2, Line 9: unique
uniquely
Done
File include/osmocom/sgsn/gprs_routing_area.h:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/7502a69a_eee4c86d?us… :
PS2, Line 34: * and for routing, the SGSN must know to which PCU a given cell is
connected.
"... and, for routing, the SGSN". […]
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/aee3fb1d_509a88bd?us… :
PS2, Line 35: 2x PCU serves
Agree with fixeria, writing like does clarifies it.
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/e7dd3a47_c2ecd07c?us… :
PS2, Line 38: individual
individually
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/2f5237c0_f8cfa01c?us… :
PS2, Line 39: has
have
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/6145ce6d_a2b53cfe?us… :
PS2, Line 47: which are alive
yeah, known_cells, active_cells, served_cells,
whatever. […]
Done
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/2da1ab82_62cd4071?us… :
PS2, Line 201: valid for GERAN
I agree, but this commit can't fix all that at the
same time.
Most of the previous api is related to geran. But will it do in a
following commit.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I59c35f1a4912ff11574bb31e4fe424816993548c
Gerrit-Change-Number: 40688
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Aug 2025 12:42:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>