Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email )
Change subject: routing area: introduce ran_type on the RA ......................................................................
Patch Set 2:
(7 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/c7d40e7a_520e232c?usp... : PS2, Line 9: unique
uniquely
Done
File include/osmocom/sgsn/gprs_routing_area.h:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/7502a69a_eee4c86d?usp... : PS2, Line 34: * and for routing, the SGSN must know to which PCU a given cell is connected.
"... and, for routing, the SGSN". […]
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/aee3fb1d_509a88bd?usp... : PS2, Line 35: 2x PCU serves
Agree with fixeria, writing like does clarifies it.
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/e7dd3a47_c2ecd07c?usp... : PS2, Line 38: individual
individually
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/2f5237c0_f8cfa01c?usp... : PS2, Line 39: has
have
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/6145ce6d_a2b53cfe?usp... : PS2, Line 47: which are alive
yeah, known_cells, active_cells, served_cells, whatever. […]
Done
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/2da1ab82_62cd4071?usp... : PS2, Line 201: valid for GERAN
I agree, but this commit can't fix all that at the same time.
Most of the previous api is related to geran. But will it do in a following commit.