pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39983?usp=email )
Change subject: Rename function s/hnbgw_decode_ranap_co/hnbgw_decode_ranap_cn_co/g ......................................................................
Rename function s/hnbgw_decode_ranap_co/hnbgw_decode_ranap_cn_co/g
This function is only used to decode UL RANAP messages. Mark it as "CN" like most other related APIs.
Change-Id: Ia4e5a21a9724ebf759b62c13759a776189b09e91 --- M include/osmocom/hnbgw/hnbgw_rua.h M src/osmo-hnbgw/context_map_rua.c M src/osmo-hnbgw/hnbgw_l3.c 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/83/39983/1
diff --git a/include/osmocom/hnbgw/hnbgw_rua.h b/include/osmocom/hnbgw/hnbgw_rua.h index b7e7ee6..55e90c0 100644 --- a/include/osmocom/hnbgw/hnbgw_rua.h +++ b/include/osmocom/hnbgw/hnbgw_rua.h @@ -13,4 +13,4 @@ int rua_tx_disc(struct hnb_context *hnb, int is_ps, uint32_t context_id, const RUA_Cause_t *cause, const uint8_t *data, unsigned int len);
-ranap_message *hnbgw_decode_ranap_co(struct msgb *ranap_msg); +ranap_message *hnbgw_decode_ranap_cn_co(struct msgb *ranap_msg); diff --git a/src/osmo-hnbgw/context_map_rua.c b/src/osmo-hnbgw/context_map_rua.c index 2d9fd8d..f73b8e2 100644 --- a/src/osmo-hnbgw/context_map_rua.c +++ b/src/osmo-hnbgw/context_map_rua.c @@ -134,10 +134,10 @@ return 0; }
-/* Decode RANAP message with convenient memory freeing: just talloc_free() the returned pointer.. +/* Decode UL RANAP message with convenient memory freeing: just talloc_free() the returned pointer.. * Allocate a ranap_message from OTC_SELECT, decode RANAP msgb into it, attach a talloc destructor that calls * ranap_cn_rx_co_free() upon talloc_free(), and return the decoded ranap_message. */ -ranap_message *hnbgw_decode_ranap_co(struct msgb *ranap_msg) +ranap_message *hnbgw_decode_ranap_cn_co(struct msgb *ranap_msg) { int rc; ranap_message *message; @@ -166,7 +166,7 @@ if (!msg_has_l2_data(ranap_msg)) return 0;
- ranap_message *message = hnbgw_decode_ranap_co(ranap_msg); + ranap_message *message = hnbgw_decode_ranap_cn_co(ranap_msg); if (message) { LOGPFSML(fi, LOGL_DEBUG, "rx from RUA: RANAP %s\n", get_value_string(ranap_procedure_code_vals, message->procedureCode)); diff --git a/src/osmo-hnbgw/hnbgw_l3.c b/src/osmo-hnbgw/hnbgw_l3.c index a6c44f7..65d9eff 100644 --- a/src/osmo-hnbgw/hnbgw_l3.c +++ b/src/osmo-hnbgw/hnbgw_l3.c @@ -314,7 +314,7 @@ * This is relevant for CN pooling, to decide which CN link to map the RUA context to. */ int hnbgw_peek_l3_ul(struct hnbgw_context_map *map, struct msgb *ranap_msg) { - ranap_message *message = hnbgw_decode_ranap_co(ranap_msg); + ranap_message *message = hnbgw_decode_ranap_cn_co(ranap_msg); if (!message) { LOGP(DCN, LOGL_ERROR, "Failed to decode RANAP PDU\n"); return -EINVAL;