Attention is currently required from: dexter, laforge, neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email )
Change subject: Change msgb ownership in processing of received msgb ......................................................................
Patch Set 3:
(3 comments)
File TODO-RELEASE:
https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/abc03d28_1318f848 PS3, Line 42: libosmocore bump_dep; workaround Bump libosmocore version dependency after I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5 I'd usually simply write: libosmocore > 1.9.0 Use my_msgb_copy_c()
So that helps quickly understand it needs some API which was added after last current release.
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/b905a34f_d9032707 PS3, Line 75: static inline struct msgb *mgw_msgb_copy_c(void *ctx, struct msgb *msg, const char *name) AS I mentioned in that patch, it may be worth having this API as a separate function in libosmocore.
https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/2f99e801_d7417b49 PS3, Line 1375: if (conn_dst == conn) I think if you do this, then you can drop the entire block of code spanning lines 1360-1365:
switch (conn_dst->mode) { case MGCP_CONN_CONFECHO: if (conn_dst == conn) continue; case MGCP_CONN_SEND_ONLY: case MGCP_CONN_RECV_SEND: ...