Attention is currently required from: pespin, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29867 )
Change subject: osmux: Make sure RTP AMR feed to osmux is in octet-aligned mode ......................................................................
Patch Set 2:
(2 comments)
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/29867/comment/78ca37c0_3c2b3d8e PS2, Line 723: * boundaries. This function is used to convert between the two modes */
Since this function was static before there was not doxygen apidoc added. […]
ack, especially if this is now public libosmo-mgcp API
File src/libosmo-mgcp/mgcp_osmux.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/29867/comment/4971680f_f3bf2a42 PS2, Line 230: /* Osmux implementation works with AMR OA only, make sure we convert to it if needed: */ i would prefer having two patches, 1) the API change to use msgb and 2) adding the conversion to OA
The actual conversion to OA seems to be a very short bit that is orthogonal to the rest, reads cluttered