Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/27520
)
Change subject: osmo-bts-trx: rx_tchh_fn(): mark valid SID frames as such
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bts-trx/sched_lchan_tchh.c:
https://gerrit.osmocom.org/c/osmo-bts/+/27520/comment/2f65a9a2_c3839941
PS1, Line 154: tch_data[0] = (0x02 << 4);
why aren't you using enum osmo_amr_type here? Furthermore, 2 seems to be AMR_5_90, not
sure why that one specifically?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/27520
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I09cec984bb60c754908126acf0300a2cc602485c
Gerrit-Change-Number: 27520
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Mar 2022 11:59:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment