Attention is currently required from: pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33336 )
Change subject: stream: Allow setting name printed during logging ......................................................................
Patch Set 2:
(3 comments)
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33336/comment/e4df6986_81d1df6b PS1, Line 317: LOGSCLI(cli, LOGL_INFO, "retrying reconnect in %d seconds...\n",
It's actually related, because I change the printing in LOGSCLI to drop the function name, so now in […]
Done
https://gerrit.osmocom.org/c/libosmo-netif/+/33336/comment/36ab5651_4f263ea2 PS1, Line 421: LOGSCLI(cli, LOGL_ERROR, "send: not connected, dropping data!\n");
Same as above, related.
Done
https://gerrit.osmocom.org/c/libosmo-netif/+/33336/comment/716afcd5_e1072a99 PS1, Line 1228: struct osmo_stream_srv_link *osmo_stream_srv_link_create(void *ctx)
Is it really needed? calling osmo_stream_srv_link_set_name() after is good enough. […]
Yesterday we were debating about keeping the API consistent. osmo_stream_{srv,cli}_create2() take name as parameter. Of course with the dynamically generated names we could choose to remove name there.