Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email )
Change subject: sgsn: Introduce test TC_attach_pdp_act_user ......................................................................
Patch Set 2:
(4 comments)
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/ccebc042_04cda... PS2, Line 614: Iu only
put `_iu_` in the name if this is Iu only?
Service Request is always Iu only, I see no need to add it everytime in the name, since it's usually going with [is_iu(ran_index)] clauses. I'm just adding it here as a comment for readers looking at this exact point.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/0da882be_b2e1c... PS2, Line 635: f_service_request
Likewise, name it `f_iu_... […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/8795391d_25aac... PS2, Line 651: [is_gb(ran_index)]
This is never true since you ensure the Iu mode above. […]
Ack, this can be dropped, I'll do so.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/a0f43883_2dacf... PS2, Line 806: completing the PDP ACT
"... […]
Done