Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624?usp=email )
Change subject: enb_proxy: add inital MME pooling support
......................................................................
Patch Set 5:
(2 comments)
File src/enb_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624/comment/250afca7_e0d45... :
PS5, Line 198: close_sock(S),
I wonder why do we close and reconnect here... shouldn't we wait until timeout?
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624/comment/44908d9a_fd3ff... :
PS5, Line 299: %% XXX: sctp_send_from_mme(Data, S),
what about this?
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I83dc4a78c78a7b87e87f5ca9a941a168d6c1dc36
Gerrit-Change-Number: 41624
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 07 Jan 2026 10:59:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No