Attention is currently required from: neels.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40633?usp=email )
Change subject: ran_peer: Introuce stats msc.ran_peers.{total,active} ......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/msc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-msc/+/40633/comment/67d27499_f1864a66?usp=... : PS4, Line 127: [MSC_STAT_RAN_PEERS_TOTAL] = { "msc.ran_peers.total", "Total RAN peers (BSC, RNC)", OSMO_STAT_ITEM_NO_UNIT, 4, 0},
(maybe add "seen"? like "Total RAN peers seen since startup" ... […]
Done
File src/libmsc/ran_peer.c:
https://gerrit.osmocom.org/c/osmo-msc/+/40633/comment/76651dc2_8240905e?usp=... : PS4, Line 95: osmo_stat_item_dec(osmo_stat_item_group_get_item(net->statg, MSC_STAT_RAN_PEERS_TOTAL), 1);
you already count the state change in onleave(), so just make sure to change the state before/on dea […]
Currently this FSM has a DISCARDING state exactly for the purpose of not being used 😄 I was even tempted submitting a patch removing it, but I didn't want to spend even more time changing existing stuff.