Attention is currently required from: jolly.
fixeria has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email )
Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure
......................................................................
Patch Set 1:
(5 comments)
File include/s1gw_metrics.hrl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/659ff3c5_e460…
:
PS1, Line 36: handover_rsp
Let's use `handover_req_ack` here.
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/9843dec1_aa19…
:
PS1, Line 640: PATH SWITCH
These PDUs are not implemented yet, so let's keep the TODO comments for them.
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/5065b38c_b7bd…
:
PS1, Line 642: fetch {MME,eNB}-UE-S1AP-ID values (mandatory IEs)
this comment is not relevant here?
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/e1a8feda_a6b1…
:
PS1, Line 1092: 'transportLayerAddress' =
TLA_In,
:
cosmetic: formatting issues
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/aa41c854_b766…
:
PS1, Line 1113: 'transportLayerAddress' =
TLA_In,
:
cosmetic: formatting issues
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08
Gerrit-Change-Number: 41006
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 03 Sep 2025 10:31:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No