Attention is currently required from: jolly.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email )
Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ......................................................................
Patch Set 1:
(5 comments)
File include/s1gw_metrics.hrl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/659ff3c5_e4605... : PS1, Line 36: handover_rsp Let's use `handover_req_ack` here.
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/9843dec1_aa196... : PS1, Line 640: PATH SWITCH These PDUs are not implemented yet, so let's keep the TODO comments for them.
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/5065b38c_b7bd5... : PS1, Line 642: fetch {MME,eNB}-UE-S1AP-ID values (mandatory IEs) this comment is not relevant here?
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/e1a8feda_a6b14... : PS1, Line 1092: 'transportLayerAddress' = TLA_In, : cosmetic: formatting issues
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/aa41c854_b766c... : PS1, Line 1113: 'transportLayerAddress' = TLA_In, : cosmetic: formatting issues