Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email )
Change subject: add ext power detect & dev reset
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
File sysmoOCTSIM/main.c:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447/comment/fe639119_ec…
:
PS7, Line 334: {
i really don't think we need one line of comments
for a 2 line function that is called extpower_dete […]
not everyone ever lookin at
that code in the future is as smart as you and knows that a change from self-powered to
bus-powered needs to be reflected in he USB descriptor and that in turn needs [at least] a
USB reset. I'm able to interpret as much into it now, but I usually assume people
reading such code have lower knowledge level or experience in the specific
codebase/product/problem area.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ied62450670dba2227daa96cbcd162cfe8414445a
Gerrit-Change-Number: 39447
Gerrit-PatchSet: 10
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Mar 2025 21:51:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>