Attention is currently required from: Hoernchen.
Patch set 10:Code-Review +1
1 comment:
File sysmoOCTSIM/main.c:
i really don't think we need one line of comments for a 2 line function that is called extpower_dete […]
not everyone ever lookin at that code in the future is as smart as you and knows that a change from self-powered to bus-powered needs to be reflected in he USB descriptor and that in turn needs [at least] a USB reset. I'm able to interpret as much into it now, but I usually assume people reading such code have lower knowledge level or experience in the specific codebase/product/problem area.
To view, visit change 39447. To unsubscribe, or for help writing mail filters, visit settings.