Attention is currently required from: laforge, pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40486?usp=email )
Change subject: bsc: generic: Introduce test TC_stat_msc_sctp_disconnected
......................................................................
Patch Set 3:
(3 comments)
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40486/comment/240f7850_8d9d…
:
PS3, Line 3275: ianctive
inactive
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40486/comment/cf8c90d6_8e03…
:
PS3, Line 3321: f_logp(BSCVTY, "Restarting msc0");
I guess the restart happens implicitly after f_bssap_idx_disconnect(0), but just to be
sure: is there something missing here?
Maybe this makes it more obvious?
```suggestion
f_logp(BSCVTY, "Waiting for msc0 restart");
```
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40486/comment/a5916ca0_ad65…
:
PS3, Line 3325: f_ctrl_get_exp(IPA_CTRL,
"stat_item.last.bsc.0.num_msc:connected", int2str(1));
Maybe use f_ctrl_exp_trap here too, so we don't need to wait the full 10s?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40486?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I028a16e2742ff0c58bf3b51ee1233ccf947a5a6a
Gerrit-Change-Number: 40486
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Jul 2025 06:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No