24 Mar
2023
24 Mar
'23
11:30 p.m.
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27391 )
Change subject: Revert "mgcp_codec: do not differentiate between oa and bwe when comparing codec" ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: See my comments in the follow up patch. I'm fine with merging this, but in general I'd go for a 2 step/function check: 1- codec is exactly the same (can be forwarded without modification. AMR OA != AMR BWE here) 2- codecs are different but can still be converted/transcoded: (AMR OA vs AMR BWE returns true here).
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27391
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I0b2854ef2397f38606fab3425be586a3d0ca27d1
Gerrit-Change-Number: 27391
Gerrit-PatchSet: 3
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Fri, 24 Mar 2023 12:30:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment