Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28914 )
Change subject: abis_om2000: move switch-case to function ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/osmo-bsc/abis_om2000.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/42ee9eaf_02cb0fbc PS1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state)
I am not sure about the naming scheme. "abis" is one layer below. […]
Why do you say abis is one layer below? AFAIU OM2K is (part of) an implementation of the Abis interface, which deviates from what is specified in TS 12.21.
abis_nm_op_sate_from_om2k_op_state() om2k_to_abis_nm_op_state()