Attention is currently required from: Timur Davydov, laforge, pespin.
fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email )
Change subject: transceiver: return -EINVAL for invalid SETSLOT
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/2b5594b6_ac8e4964?usp=... :
PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */
If you return early, you bypass `transceiver->ctrl_sock_send()` and the error response is never sent […]
Nevermind, I got confused and thought both parts of the diff belong to the same function.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53
Gerrit-Change-Number: 42421
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov
dtv.comp@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: Timur Davydov
dtv.comp@gmail.com
Gerrit-Comment-Date: Tue, 17 Mar 2026 13:46:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: Timur Davydov
dtv.comp@gmail.com
