[M] Change in osmo-bsc[master]: requires_voice_stream -> ch_indctr

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31622 ) Change subject: requires_voice_stream -> ch_indctr ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: You could even move this function to libosmocore. File include/osmocom/bsc/gsm_08_08.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31622/comment/8f1c90b3_15082d52 PS1, Line 16: bool bsc_requires_rtp_stream(enum gsm0808_chan_indicator ch_indctr); this function name sounds weird. Name seems to indicate it's some sort of global config, but you are actually simply checking stuff on chan_ind. chan_ind_requires_rtp_stream sounds more accurate? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1538c1e6d5cd61559af7c1e2860afd0269dda367 Gerrit-Change-Number: 31622 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Mar 2023 14:33:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment