Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348?usp=email )
Change subject: Fix 'update route' vty command
......................................................................
Patch Set 3:
(2 comments)
File src/osmo_ss7_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348/comment/6d61c932_5b4ed…
:
PS3, Line 344: linkset LS_NAME [priority] [PRIO] [qos-class] [(CLASS|default)]
Something is still wrong with the interactive help:
[…]
I'm fixing it in a follow-up commit, it's another unrelated bug.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348/comment/365f4d8c_cf3b2…
:
PS3, Line 397: return CMD_WARNING;
print an error here?
Acknowledged
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I28d3b587ae5d6ca7f494221e2bfc39357a45736d
Gerrit-Change-Number: 38348
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Oct 2024 16:06:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>