Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email )
Change subject: bring twrtp into libosmo-netif
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/twrtp.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/70fe5759_2bdfb0b… :
PS6, Line 231: endp->iofd_rtp = osmo_iofd_setup(endp, -1, NULL,
Did you think about deferring this allocation step until osmo_twrtp_supply_fds is called?
at least for iofd_rtcp which may never be used based on config.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb
Gerrit-Change-Number: 39281
Gerrit-PatchSet: 6
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Mon, 25 Aug 2025 09:50:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes