Attention is currently required from: fixeria.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33471 )
Change subject: ECU in UL path: move it from trx model to l1sap ......................................................................
Patch Set 1:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33471/comment/23805c49_d195443d PS1, Line 1852: gsm_fn2gsmtime
`l1sap_tch_ind()` does this calculation before calling this new helper function, so maybe accept a ` […]
Yup, I was uneasy with this part too when I wrote it. I thought about simply removing that log line, but reasoning that "removing functionality for no good reason is not the way of FOSS", I did the current approach. I'll make a new version of this last patch changing it to (const struct gsm_time *) passing like you suggested.