Change in libosmocore[master]: VTY: avoid printing duplicate rate_ctr/stat_item groups

Attention is currently required from: laforge, fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27409 ) Change subject: VTY: avoid printing duplicate rate_ctr/stat_item groups ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not sure this assumption is correct. The way to go, imho, would be to use a hashtable or rbtree (based on a stack allocated pool of structs to store data), with key=group_name, so that we keep track over the groups already printed. If done this way it's pretty efficient in memory use as well as allocation (no heap allocation occurs). I did this recently in open5gs to track repeated IEs in TLV, see https://github.com/open5gs/open5gs/pull/1351/commits/1a518bff735b6c34639df4… -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1e66bc5720dfe255b480780aa9a0b76f4c0cc1fe Gerrit-Change-Number: 27409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:48:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment