Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35914?usp=email )
Change subject: gsm: add TCH block/lchan definitions for CSD
......................................................................
Patch Set 2:
(1 comment)
File src/gsm/gsm44021.c:
https://gerrit.osmocom.org/c/libosmocore/+/35914/comment/10722539_a12b4204
PS2, Line 30: if 0
: [GSM48_CMODE_DATA_14k5] = {
: /* TCH/F14.4: 290 bits every 20 ms (14.5 kbit/s) */
: .fr = { .num_frames = 1, .num_bits = 290 },
: },
: #endif
i'm not quite sure I like that kind of
commented-out data structure in libosmocore. […]
The problem here is that I was not
sure whether this definition is correct, so this is why I left this entry commented out. I
just checked 3GPP TS 44.021, section 10.3.2, and found out that a radio block for
TCH/F14.4 consists of 8 modified V.110 frames (36 bits each) plus the `M1`/`M2` bits.
I'll update the patch.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35914?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie230e09d496c9b791981d8ee04902fc9966ed6d7
Gerrit-Change-Number: 35914
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 10 Feb 2024 16:13:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment