Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 )
Change subject: tweak lots of logging ......................................................................
Patch Set 7:
(2 comments)
File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/3543a991_7b1dee0e PS3, Line 515: LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "using: cs7-%u %s <-> %s %s %s\n",
I am not using multi line logging here ... ? […]
#define CNLINK_PRINT_FMT "cs7-%u %s <-> %s %s %s" #define CNLINK_PRINT_ARGS(cnlink) ss7->cfg.id, \ osmo_ss7_pointcode_print(ss7, cnlink->hnbgw_sccp_user->local_addr.pc), \ osmo_ss7_pointcode_print2(ss7, cnlink->remote_addr.pc), \ cnlink->name, cnlink->use.remote_addr_name ? : "(default remote point-code)"
File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/3b6a289c_b8e52303 PS7, Line 635: hnbgw_cnlink_log_self(cnlink); LOGP(DCN, LOGL_NOTICE, "Using " CNLINK_PRINT_FMT "\n", CNLINK_PRINT_ARGS(cnlink));
(or simply copy the entire log line if you are really expecting to use it twice).
Also, I'm note sure why cannot LOG_CNLINK or alike be used there instead. Maybe LOG_CNLINK should be extended with more info?