Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/32085
)
Change subject: msc_main: close SMS db on startup error
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File src/osmo-msc/msc_main.c:
https://gerrit.osmocom.org/c/osmo-msc/+/32085/comment/d1a2dedf_0b490d23
PS1, Line 805: db_fini();
really looks like you want to use a goto here....
https://gerrit.osmocom.org/c/osmo-msc/+/32085/comment/fd52a6db_3bbe3b7e
PS1, Line 829: db_fini();
to here....
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/32085
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9bb799048db5fcdb2a2520107bd75d5f7a865459
Gerrit-Change-Number: 32085
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Mar 2023 14:34:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment