Attention is currently required from: jolly.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email )
Change subject: ASCI: Add channel notification event to MM events
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/0b53aacc_b9d2ef6f
PS5, Line 170: uint8_t sres[4];
the sres is used with all events? or with some specific event only?
https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/f9f6dde3_99ee7a05
PS5, Line 171: struct {
Mention the related type somehow, example:
struct { /* GSM48_MM_EVENT_NOTIFICATION */
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ifee286ba4628356cc19b5dc75f1843287c5d2342
Gerrit-Change-Number: 34488
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 21 Sep 2023 12:56:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment