Attention is currently required from: dexter.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720 )
Change subject: MGW_Tests: Add test for "confecho" connection.
......................................................................
Patch Set 2:
(2 comments)
File mgw/MGCP_Test.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720/comment/d56c68d3_df2b…
PS1, Line 2309: f_flow_delete(RTPEM[1]);
In TC_two_crcx_and_one_mdcx_rtp_ho we do this the
other way around, I don't remember where the catch […]
I moved "ep,
call_id" to second command.
I stop the talker's RTP flow (0) before stopping the listener's flow (1), so that
there is no race condition in missing a packet. The listener must receive as many packets
as the talker transmits. (I hope I got that right.)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720/comment/1dc9d6a0_4e97…
PS1, Line 2317: setverdict(fail);
the setverdict also supports a string to explain what
failed. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7df4a58ad9287a564b2daf7548b882c03787f7f2
Gerrit-Change-Number: 33720
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Jul 2023 12:15:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment