Attention is currently required from: neels.
Jenkins Builder has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email )
Change subject: osmo-pfcp-tool: add GTP flooding using io_uring ......................................................................
Patch Set 2:
(4 comments)
File src/osmo-pfcp-tool/pfcp_tool.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17590): https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/29dbdd83_6e800e07?usp=... : PS2, Line 225: if (osmo_sockaddr_cmp(&port->osa, osa) == 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17590): https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/0b57fb7d_934a1f00?usp=... : PS2, Line 339: llist_for_each_entry(peer, &g_pfcp_tool->peers, entry) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17590): https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/f4507b00_99580359?usp=... : PS2, Line 341: llist_for_each_entry(session, &peer->sessions, entry) { space required before the open parenthesis '('
File src/osmo-pfcp-tool/pfcp_tool_vty.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17590): https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/d6d6a5e2_ee63b383?usp=... : PS2, Line 179: ) please, no spaces at the start of a line