Attention is currently required from: laforge, osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40501?usp=email )
Change subject: asp: Support Tx DAUD when ASP becomes activated
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/xua_asp_fsm.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40501/comment/8c35239c_c1d1b5... :
PS5, Line 161: llist_for_each_entry
cosmetic: maybe add a comment that here you count affected PCs in order to allocate enough memory?
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40501/comment/0494ed6d_710882... :
PS5, Line 172: talloc_size(asp, sizeof(*aff_pc) * num_aff_pc);
```
talloc_array(asp, uint32_t, num_aff_pc);
```
(not critical)
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40501?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I7c8c5099d4d00ea6f4a8db59ed6b833fb0ffa43d
Gerrit-Change-Number: 40501
Gerrit-PatchSet: 5
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 15 Jul 2025 18:30:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
