Attention is currently required from: fixeria.
bjoern has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/26959 )
Change subject: implement shell command to update PLMN in IMSI
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
fixed both issues in the patchset2
File pySim/ts_51_011.py:
https://gerrit.osmocom.org/c/pysim/+/26959/comment/1323d9b3_19ce9c84
PS1, Line 485: string
There is no such type in Python, should be
'str' instead.
Done
https://gerrit.osmocom.org/c/pysim/+/26959/comment/0f6a7d24_45406566
PS1, Line 488: if len(plmn) == 5:
If I am not mistaken, it can also be 6 in case of
3-digit MNC.
Ack
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/26959
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc
Gerrit-Change-Number: 26959
Gerrit-PatchSet: 2
Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Jan 2022 11:17:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment