Attention is currently required from: osmith, pespin.
laforge has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-pcap/+/39343?usp=email )
Change subject: server: Use osmo_stream_srv for non-tls read tcp sock
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcap/+/39343/comment/07f97451_58bf0f4b?us… :
PS2, Line 9: TLS handling adds a lot of complexity, so TLS sockets are still read
: through the previous code paths, and conversion to osmo_stream_srv is
: left as a future improvement.
I spent some time at the start trying to already
integrate the TLS stuff into the new osmo_stream ba […]
Yeah, I was not implying you
should do it now. I'm just saying _if_ one wants to do it, it should probably be a
generic library code.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39343?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I537620fcad6c8e65206a41a1c21bd4b6453fbed4
Gerrit-Change-Number: 39343
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Jan 2025 21:02:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>