pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33308 )
Change subject: mgcp-client: Add keepalive feature ......................................................................
Patch Set 5:
(1 comment)
File src/libosmo-mgcp-client/mgcp_client_vty.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/33308/comment/8639f60e_77a38f3f PS5, Line 674: cli && cli->conn_up ? "UP" : "DOWN", After applying Harald's idea, this line would be something like:
cli && cli->conn_up ? ((mgcp->actual.keepalive.timeout_sec > 0) ? "UP" : "MAYBE") : "DOWN"
Regarding dexter comment, I don't really like the "available"/"unavailable" that much, because that could be maybe understood as the status of the MGW, where we really want to talk about the status of the link towards it here. I can change the naming though if there's a general consensus though.