Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email )
Change subject: Add test for tcap decoding/encoding
......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS1:
Yes, good idea to have it in the library. […]
Done
File tests/testsuite.at:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308/comment/4bfa1d5e_722852... :
PS2, Line 23: if BUILD_WITH_TCAP_LOADSHARING
I am not sure if this syntax is valid. AFAICS, only libosmocore. […]
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308/comment/5016b57c_bad814... :
PS2, Line 23: if BUILD_WITH_TCAP_LOADSHARING
I am not sure if this syntax is valid. AFAICS, only libosmocore. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2
Gerrit-Change-Number: 41308
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: daniel
dwillmann@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Sun, 09 Nov 2025 11:32:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu
