pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27879 )
Change subject: rsl_rx_ccch_load: add explicit cast -1 to unsigned ......................................................................
rsl_rx_ccch_load: add explicit cast -1 to unsigned
This is useful for the reader to understand those variables are actually ungisned, so they should never be compared later against isgned values. It helps understand -1 here means the maximum unsigned value.
Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/79/27879/1
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 03e409d..0486afc 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2328,9 +2328,9 @@ struct ccch_signal_data sd;
sd.bts = sign_link->trx->bts; - sd.rach_slot_count = -1; - sd.rach_busy_count = -1; - sd.rach_access_count = -1; + sd.rach_slot_count = (uint16_t)-1; + sd.rach_busy_count = (uint16_t)-1; + sd.rach_access_count = (uint16_t)-1;
switch (rslh->data[0]) { case RSL_IE_PAGING_LOAD: