Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email )
Change subject: gtp_endpoint: Avoid deadlocks logging while thread is cancelled
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File daemon/gtp_endpoint.c:
https://gerrit.osmocom.org/c/osmo-uecups/+/40788/comment/0d8b6a5f_bda61e9b?… :
PS1, Line 89: LOGEP(ep, LOGL_NOTICE, "Short GTP Message according to flags
0x%02x: %lu < len=%u\n",
missing `pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused);` before
this line?
https://gerrit.osmocom.org/c/osmo-uecups/+/40788/comment/93b9dcb4_5946f603?… :
PS1, Line 96: LOGEP(ep, LOGL_NOTICE, "Short GTP Message according to flags
0x%02x: %lu < len=%u\n",
missing `pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancelst_unused);` before
this line?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb
Gerrit-Change-Number: 40788
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Jul 2025 09:44:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes