Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27863 )
Change subject: utils/meas_pcap2db: fix -Wpointer-sign in pcap_cb()
......................................................................
Patch Set 2:
(1 comment)
File src/utils/meas_pcap2db.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27863/comment/c8351f3f_62cf80ec
PS1, Line 64: const char *cur = (const char *)bytes;
why not simply change "cur" to be u_char or
uint8_t?
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27863
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I84d8e6f290bda0f03476f182f292ecc7a9e520f2
Gerrit-Change-Number: 27863
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Apr 2022 13:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment