25 Feb
2026
25 Feb
'26
11:57 a.m.
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email )
Change subject: bankd: csv: fix crash on invalid lines ......................................................................
Patch Set 1:
(1 comment)
File src/bankd/bankd_pcsc.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42200/comment/a4d1e5df_a00b15ba?u... : PS1, Line 105: LOGP(DMAIN, LOGL_ERROR, "B%d:%d: No reader name given. Maybe invalid csv.\n",
looks ike we want to add a LOG define for sn here :)
Yes, but the logging is still a good topic to change things.I would like to do the topic in a different commit, because it is a general problem and this fixes a crash here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42200?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Id6059c7dd4a119ffb1658a6cd7345a40bef3a69f
Gerrit-Change-Number: 42200
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 25 Feb 2026 10:57:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de