2 May
2023
2 May
'23
2:52 p.m.
Attention is currently required from: neels, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32549 )
Change subject: Fix 'Fix parsing of TLV_TYPE_SINGLE_TV' ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File tests/tlv/tlv_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/32549/comment/3e38b93c_6f83d794 PS2, Line 478: OSMO_ASSERT((*val & 0x0f) == exp_val); I think it makes sense to document somewhere (e.g. in the TLV_TYPE_SINGLE_TV variant) that masking the value is needed.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32549
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id619459c17976b77cd2c7e4179123bb06807285c
Gerrit-Change-Number: 32549
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 02 May 2023 12:52:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment