13 Feb
2023
13 Feb
'23
3:32 a.m.
Attention is currently required from: jolly, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31034 )
Change subject: Add setting of Sa bits to misdn driver ......................................................................
Patch Set 7:
(1 comment)
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31034/comment/e3766c99_027fee8d PS7, Line 314: (sa_bits >> 4) & 1, (sa_bits >> 5) & 1, sa_bits & 1, (sa_bits >> 6) & 1, sa_bits >> 7); (just saying because it was discussed before: this indent is fine. it doesn't align with the opening brace, but indenting by a single tab is also good)
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31034
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I54205a2534a7638cc071888d853f9d6d312dc9f0
Gerrit-Change-Number: 31034
Gerrit-PatchSet: 7
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: neels nhofmeyr@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 13 Feb 2023 02:32:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment