Attention is currently required from: daniel, dexter, laforge, neels.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42353?usp=email )
Change subject: docs/put_key: add tutorial that explains how to manage global platform keys ......................................................................
Patch Set 4:
(7 comments)
File docs/put_key-tutorial.rst:
https://gerrit.osmocom.org/c/pysim/+/42353/comment/9a08cf9e_2c3d4711?usp=ema... : PS4, Line 16: It It's
https://gerrit.osmocom.org/c/pysim/+/42353/comment/7ceaf48a_a1171787?usp=ema... : PS4, Line 39: exists [two domains] exist
https://gerrit.osmocom.org/c/pysim/+/42353/comment/e1e6bc27_6b31c18e?usp=ema... : PS4, Line 46: there will there will be
https://gerrit.osmocom.org/c/pysim/+/42353/comment/f176888e_78814630?usp=ema... : PS4, Line 67: we simply have `pySim-shell` : into making the GlobalPlatform related commands available something is not right here, do you mean "we simply force pySim-shell"?
https://gerrit.osmocom.org/c/pysim/+/42353/comment/580b829a_2579c42a?usp=ema... : PS4, Line 91: Along with the card we have received the following keyset: Maybe add an extra warning/clarification here that each card has its own unique keyset, and the given example values are not valid for other cards?
https://gerrit.osmocom.org/c/pysim/+/42353/comment/3640903d_6550ce3e?usp=ema... : PS4, Line 108: establish_scp02 Don't we need to specify `--key-ver 122` here?
https://gerrit.osmocom.org/c/pysim/+/42353/comment/078ef73b_2442bb88?usp=ema... : PS4, Line 440: That different schemes are possible shows the second example Looks like the halves of this sentence are swapped. How about: "the second example shows that different ]]ъu are possible"?