[M] Change in osmo-ttcn3-hacks[master]: msc: split off f_mo_call_establish__handle_assignment_request()

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email ) Change subject: msc: split off f_mo_call_establish__handle_assignment_request() ...................................................................... Patch Set 2: (4 comments) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/5a570a53_ec3c… PS2, Line 1666: ts_CodecFR for illustration, this hardcoded FR is what I ultimately want to vary in the upcoming patch, because TCH assignment may want to test for correct codec decisions. The CSData two lines above will always stay constant AFAICT. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/b6ae4d7a_3141… PS2, Line 1557: f_mo_call_establish__handle_assignment_request yes, the idea is that it is a sub-part of f_mo_call_establish(), and to not confuse the reader into "what, establish a handle?". let me know if that's fine. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/69c7529b_345b… PS2, Line 1573: not match(ass_req.pdu.bssmap.assignmentRequest.aoIPTransportLayer, tla_ass1 ah i see. i agree; but not going to change it in this patch. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/bf7d5dc7_7fc2… PS2, Line 1690: valueof(ts_CodecFR i did consider that. i kept it this way because only TCH needs various codecs, and csd ALWAYS needs CSData; so one could consider the arg to pass in the default TCH codec, and CSD uses CSData always anyway. The argument you make weighs about the same. So then I chose to not invest time... does that sound good or a lame excuse? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I98c6171a592dfe1573e15136c4ecf4ff234048d7 Gerrit-Change-Number: 35052 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Nov 2023 01:06:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment