Attention is currently required from: fixeria.

View Change

4 comments:

• File msc/BSC_ConnectionHandler.ttcn:

  • Patch Set #2, Line 1666: ts_CodecFR

    for illustration, this hardcoded FR is what I ultimately want to vary in the upcoming patch, because TCH assignment may want to test for correct codec decisions. The CSData two lines above will always stay constant AFAICT.

  • Patch Set #2, Line 1557: f_mo_call_establish__handle_assignment_request

    Hmm, I find the double low-dash a bit weird, but guessing you did it intentionally?

    yes, the idea is that it is a sub-part of f_mo_call_establish(), and to not confuse the reader into "what, establish a handle?". let me know if that's fine.

  • Patch Set #2, Line 1573: not match(ass_req.pdu.bssmap.assignmentRequest.aoIPTransportLayer, tla_ass1

    btw, this matching statement can be simplified a bit to: […]

    ah i see. i agree; but not going to change it in this patch.

  • Patch Set #2, Line 1690: valueof(ts_CodecFR

    Hmm, so now you're explicitly passing `ts_CodecFR`, but the new function may overwrite it to `ts_Cod […]

    i did consider that. i kept it this way because only TCH needs various codecs, and csd ALWAYS needs CSData; so one could consider the arg to pass in the default TCH codec, and CSD uses CSData always anyway.
    The argument you make weighs about the same. So then I chose to not invest time...
    does that sound good or a lame excuse?

To view, visit change 35052. To unsubscribe, or for help writing mail filters, visit settings.