Attention is currently required from: daniel, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email )
Change subject: osmo_io: Move notify_connected function to backend
......................................................................
Patch Set 2:
(2 comments)
File src/core/osmo_io_poll.c:
https://gerrit.osmocom.org/c/libosmocore/+/35909/comment/40dfa40a_1268c68a
PS2, Line 115: if (osmo_fd_is_registered(ofd))
This is expensive!!! […]
Replaced by flag.
https://gerrit.osmocom.org/c/libosmocore/+/35909/comment/fe5cf19d_e308baed
PS2, Line 125: if (!osmo_fd_is_registered(ofd))
This is expensive!!! […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I905ec85210570aff8addadfc9603335d04eb057a
Gerrit-Change-Number: 35909
Gerrit-PatchSet: 2
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Thu, 22 Feb 2024 10:00:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment