Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email )
Change subject: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls()
......................................................................
Patch Set 1:
(1 comment)
File mncc_mt_loadgen.py:
https://gerrit.osmocom.org/c/mncc-python/+/39143/comment/e188830a_fbf3661a?u... :
PS1, Line 185: if len(first_msisdn_called) > needed_len:
Can this if condition ever be true? as I understand it, nr is always >= 1. […]
nr=3 first_msisdn_called='00000', so that it produces:
"00000"
"00001"
"00002"
instead of
"0"
"1"
"2"
--
To view, visit
https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I2dd6b96ea2da117d67a368bc076969f25fa61a52
Gerrit-Change-Number: 39143
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Comment-Date: Mon, 16 Dec 2024 10:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
osmith@sysmocom.de